Note Assist, automatic note generation & resize.

@itsonlyaname: Update! Changelog: New feature: Ctrl-click* a...

2015-05-15T15:49:31-04:00

Update!

Changelog:

New feature: Ctrl-click* a existing note to resize it (per type-kun's idea)

- Most of the logic & code re-written so people can actually read what is happening.
- Accuracy in detecting text remains about the same, I've pretty much hit a dead end trying to improve it.
- speed increase on everything!
- memory usage remains the same
- moved script objects to it's own namespace, improves cross-browser support & maintainability.
- much less likely to break when danbooru updates

*Can be bound to shift- or ctrl-shift-click

And since it's on git now, anyone is free to create issues / pull requests :)

Edit;
2015-07-10 - v1.1:
- New button: "save all non-ghost notes" to make it easier to reposition a lot of notes.
- Notes resized by the script now are properly marked as "unsaved"

@itsonlyaname: I'm still here :p Moved to git. So, it's been...

2015-04-07T15:17:40-04:00

I'm still here :p

Moved to git.
So, it's been about 2 years since the code has been touched. Perhaps it's time for some code cleanup, if i changed it a bit so it doesn't use so much hard-coding anymore, it could be quite useful for any text-detection application.
It's vacation right now, so i might be able to work on it for a bit :)
Edit, there's a lot more code than i remember (2000 lines), working on it slowly but surely.

@Type-kun: This script shouldn't die. With some polishing,...

2015-04-07T14:50:47-04:00

This script shouldn't die. With some polishing, it should get incredibly useful for both translation and note gardening. I've made a little (ugly) tweak to bind ctrl+click on any existing note to resize it on the text inside - and this is STILL awesome in how much it simplifies working with notes. Itsonlyaname, are you still here? Maybe move the script to github so anyone could contribute/send pull requests? Also github probably won't go down like userscripts did.

@itsonlyaname: Updated. Thanks for the detailed reports :)

2013-09-08T03:48:58-04:00

Updated.

Thanks for the detailed reports :)

@Toks: Needs to be updated again with the change from...

2013-09-08T02:06:19-04:00

Needs to be updated again with the change from issue #1948.

@itsonlyaname: Fixed. As one might have guessed, i no longer...

2013-08-21T08:39:18-04:00

Fixed.

As one might have guessed, i no longer have the time or motivation to add new features to the script, but i'll try to keep it working.

@Toks: I seem to have broken this when I fixed issue...

2013-08-20T22:16:22-04:00

I seem to have broken this when I fixed issue #1675. Notes jump around instead of being created where I drag.

It looks like it can be fixed by replacing lines 1312 to 1336 of the userscript (the override of the old Danbooru.Note.TranslationMode.create_note function) with this:

Danbooru.Note.TranslationMode.create_note = function(e,x,y,w,h) {
    var offset = $("#image").offset();

    if (w > 9 || h > 9) { /* minimum note size: 10px */
      if (w <= 9) {
        w = 10;
      } else if (h <= 9) {
        h = 10;
      }
      Danbooru.Note.create(x - offset.left, y - offset.top, w, h, e); // custom code - added event to parameters
    }

    $("#note-container").css('visibility', 'visible');
    e.stopPropagation();
    e.preventDefault();

    // Hack to ignore clicks for some milliseconds
    // The mouseup event is executed before the click event, so it's hard to do this properly
    Danbooru.Note.ignore_click_until = (new Date).getTime() + 200;
  }

That just updates the overridden function with the changes I made.

@itsonlyaname: Fixed, forgot to rename some stuff

2013-05-30T13:03:36-04:00

Fixed, forgot to rename some stuff

@Type-kun: "Create all" stopped working in opera, outputs...

2013-05-30T12:08:03-04:00

"Create all" stopped working in opera, outputs errors to the console.

@itsonlyaname: v0.10 - Updated for danbooru v2.14.0

2013-05-30T11:19:56-04:00

v0.10
- Updated for danbooru v2.14.0

@Toks: This doesn't seem to work very well with 2.14's...

2013-05-30T10:13:11-04:00

This doesn't seem to work very well with 2.14's translation mode.

@itsonlyaname: v0.9 - Added settings menu No setting for the...

2013-05-28T15:02:28-04:00

v0.9
- Added settings menu

No setting for the red/green buttons atm, they will be moved inside the note edit box as per Type-kun's suggestion (Which looks great btw :D)

@Type-kun: Edit box after some tampering:...

2013-05-25T17:59:07-04:00

Edit box after some tampering: http://puu.sh/315Lg.png

The hook looks simple enough:
if (Danbooru.meta("current-user-name") !== "Anonymous") { $(".note-body").unbind('click'); $(".note-body").click(function(e) { var $note_body_inner = $(e.currentTarget); Danbooru.Note.Edit.show($note_body_inner); $(".note-edit-dialog .ui-dialog-content").before("<div id='customcontrols' style='text-align:center'></div>"); $("#customcontrols").append('We can have nice things'); e.stopPropagation(); }) }
. The buttons doesn't work yet though, I presume they should be rendered in the separate document fragment, bound to events and then attached.

@itsonlyaname: > Toks said: > > I'm probably overlooking...

2013-05-22T07:57:59-04:00

Toks said:

I'm probably overlooking something, but I don't see why it would be bad in those cases. It just needs to go inside the innermost tag.

Ah, now i see what you mean. The current detection is a simple "if text is selected -> apply to that text // otherwise -> apply to whole note".
Changing it to something like "any selected texted? if not -> find if the cursor is inside any tags? if not -> apply to whole note." would work fine i guess.

Oh, so that red button actually does resize it to fit. I thought the buttons just resized it by a fixed amount (which wouldn't be particularly useful). In that case, they would be reasonable once they're more usable.

Toks said:

Oh, so that red button actually does resize it to fit.

Yep, red resizes, green expands by 5px all sides. Those buttons are what i used to test the code before mixing it with click & drag.

@Toks: > itsonlyaname said: > > That is possible, but...

2013-05-21T21:32:01-04:00

itsonlyaname said:

That is possible, but i feel that might not be desired in some cases. Like, when trying to use both "bold" & "italic", or "bold" then "color".

I'm probably overlooking something, but I don't see why it would be bad in those cases. It just needs to go inside the innermost tag.

itsonlyaname said:

Would this still be needed if the resize buttons changed to be much cleaner and smaller? (so they won't get in the way even if the setting is always active)

@itsonlyaname: v0.8 - Moved eyedropper preview to below the...

2013-05-21T20:34:23-04:00

v0.8
- Moved eyedropper preview to below the buttons
- Added preview text to the eyedropper function
- Fixed rare bug where note could be 1-2px out of the image
- Added 'x' button to close the Note Assist window
- Changed "instantNote" setting to default "true"

Haven't had much time to sit down & code lately...
No slider to adjust colors (yet?).

Type-kun said:

Suggestions:
1) Can you move text coloring controls inside the actual note edit box? I think they belong there.

That should be possible, but the layout could be tricky. The eyedropper preview is way to large to add to the note edit box so we'd end up splitting the button and the preview.

Type-kun said:

2) SO misses the control to resize an already-existing note to fit the text. Maybe also inside the edit box.

Try the "noteAssist_noteButtons" setting, the buttons look kinda horrible though.

Type-kun said:

UPD:
Oh, and also 3). Could you make an option to override note creation behavior? Instead of "N + click or drag to create" -> "drag to create notes, click toggle notes, disregard small(accidental) drags as clicks, no keyboard involved". Maybe this should actually be in the main code, though.

issue #1496 :)

Type-kun said:

4) I see no way to close note assist window except refreshing the page

*Added a button*

Toks said:

After pressing one of the buttons (eg. Italic), could the cursor be positioned inside of the html tags, instead of having the entire content selected? That would be more convenient so I could start typing instantly, instead of manually repositioning the cursor constantly.

That is possible, but i feel that might not be desired in some cases. Like, when trying to use both "bold" & "italic", or "bold" then "color".

Toks said:

What I'd like to see is a button you can click to instantly resize all existing notes. By "resize", I mean what it does automatically when you drag to create a new note.

Would this still be needed if the resize buttons changed to be much cleaner and smaller? (so they won't get in the way even if the setting is always active)

I'm starting to think the script is pretty much ready/stable. Of course there will always be maintenance/bugfixes/feature requests, but the core part seems to work pretty well now.
This heavily depends on feedback though, since i very rarely actually use my script :p

I don't really have any more idea's to further improve the text-detection code (tons of performance improvements left, but it's not so fun to re-write code for the 10th time)

@Toks: After pressing one of the buttons (eg. Italic),...

2013-05-16T13:05:42-04:00

After pressing one of the buttons (eg. Italic), could the cursor be positioned inside of the html tags, instead of having the entire content selected? That would be more convenient so I could start typing instantly, instead of manually repositioning the cursor constantly.

itsonlyaname said:

Yea, they aren't fully implemented since I'm not sure what to do with them.
Maybe I'll replace with smaller buttons, attached to the left side, half overlapping the note box. (+ some other quick buttons - all buttons accessible with shift-click only)

What I'd like to see is a button you can click to instantly resize all existing notes. By "resize", I mean what it does automatically when you drag to create a new note.

itsonlyaname said:

Not a clue, looks like it was just a normal note in the middle of an image.

Turns out that's actually a bug with the site, not your script. issue #1623

@Type-kun: Finally got to actually test it. It's even...

2013-05-13T13:22:43-04:00

Finally got to actually test it. It's even better in action than it is in theory :3

Suggestions:
1) Can you move text coloring controls inside the actual note edit box? I think they belong there.

2) SO misses the control to resize an already-existing note to fit the text. Maybe also inside the edit box.

UPD:
Oh, and also 3). Could you make an option to override note creation behavior? Instead of "N + click or drag to create" -> "drag to create notes, click toggle notes, disregard small(accidental) drags as clicks, no keyboard involved". Maybe this should actually be in the main code, though.

4) I see no way to close note assist window except refreshing the page

@itsonlyaname: > Type-kun said: > > Take a look at...

2013-05-13T10:29:01-04:00

Type-kun said:

Take a look at http://jqueryui.com/slider/#colorpicker - this way is simple enough. It's RGB though, moving it to HSV would require some math.

That looks simple enough, I'll move the colorpicker/preview to a new box.
Larger preview, a slider to adjust brightness and some sample text that instantly gets colored.
At least, if a brightness slider is enough - HSV is kind of a pain to calculate (i can always import someone else's code though).

@Type-kun: > itsonlyaname said: > > Properly tweaking HSV...

2013-05-13T01:49:11-04:00

itsonlyaname said:

Properly tweaking HSV would probably require a full editor though, something like (image), which feels like it'd take a lot of space / time to code.
How about simply making the color gotten from the eyedropper about... 10~20%? darker?

Take a look at http://jqueryui.com/slider/#colorpicker - this way is simple enough. It's RGB though, moving it to HSV would require some math.