[Feature Idea] Permanent Blacklist

@BrokenEagle98: > chinatsu said: > > Wouldn't this still load...

2017-11-24T14:04:31-05:00

chinatsu said:

Wouldn't this still load the objectionable content to someone's cache?

Yes. If that's a concern, then many browsers offer incognito tabs/windows.

@chilled_sake: Wouldn't this still load the objectionable...

2017-11-24T04:10:34-05:00

Wouldn't this still load the objectionable content to someone's cache?

@BrokenEagle98: Okay... it took a while, but I believe the...

2017-06-07T23:34:22-04:00

Okay... it took a while, but I believe the below should be good.

/*Blacklist thumbnails hidden (Common case)*/
.post-preview {display: none;}
.post-preview.blacklisted {display: block;}
.post-preview.blacklisted.blacklisted-active {display: none;}

/*Blacklist thumbnails hidden (Parent/child exception)*/
#has-parent-relationship-preview .blacklisted:not(.blacklisted-active) {display: inline-block;}
#has-children-relationship-preview .blacklisted:not(.blacklisted-active) {display: inline-block;}

/*Blacklist image hidden*/
#image-container {display: none;}
#image-container.blacklisted {display: block;}
#image-container.blacklisted.blacklisted-active {display: none;}

Details

1. Every image container was block format with the exception of parent/child containers, which were inline-block.
2. Included an implementation for full-size images, which was missing in the original.
3. Removed dependency on order by taking advantage of CSS priority calculations.

Edit:

(2017-07-11)

I updated the above with a fix in forum #132142. Basically, a recent change causes no posts to appear on pages without blacklist controls. The following code was used to address this on the pages found to have this problem.

/*Temp settings*/
#c-pool-orders #a-edit .post-preview,
#c-favorite-group-orders #a-edit .post-preview,
#c-artists #a-show .post-preview {
    display: inline-block;
}

(2017-07-21)

The issue has been fixed, so the temporary settings from above are no longer required.

@BrokenEagle98: > kittey said: > > Sorry for undermining your...

2017-06-07T16:21:11-04:00

kittey said:

Sorry for undermining your efforts by finding more issues, but the “current image” border in the parent/child bars doesn’t play nicely with inline: example. The grey border should be all around the thumbnails, not just two small bars to the left and right.

No worries...thanks for reporting all of these errors. I want to make it as error free as possible. This will probably require very specific selectors. I'll post something up by the end of the day PST.

@Claverhouse: Sounds nice. Never had the flickering myself,...

2017-06-07T16:00:07-04:00

Sounds nice. Never had the flickering myself, but I treasure my blacklist.

I get depressed enough at just non-blacklisted heavily sad stuff without risking seeing torture and Grand Guignol.

@kittey: > BrokenEagle98 said: > > Ok, I went back, and...

2017-06-07T13:15:22-04:00

BrokenEagle98 said:

Ok, I went back, and found that the inline value currently works in all places.

Post show (w/child and w/parent)

Sorry for undermining your efforts by finding more issues, but the “current image” border in the parent/child bars doesn’t play nicely with inline: example. The grey border should be all around the thumbnails, not just two small bars to the left and right.

@BrokenEagle98: > kittey said: > > No, I wasn’t talking about...

2017-06-07T12:38:41-04:00

kittey said:

No, I wasn’t talking about the missing blacklist box. I was talking about how some comments and thumbnails are put next to others instead of all below each other.

Without your CSS - With your CSS

Also note that the quotation boxes don’t stretch to full width even with just one comment per row.

Ok, I went back, and found that the inline value currently works in all places.

.post-preview.blacklisted {display: inline;}

Tested:

Users page
Post index
Post show (w/child and w/parent)
Popular posts
Favorites
Favgroup show
Pool gallery
Pool show
Comment (group by post)
Comment (group by comment)
Artist commentary index
Post appeal
Post flag
Moderator dashboard

Additioally, I found a couple extra places that don't have a blacklist box, which I'll be adding to issue #3121.

@kittey: No, I wasn’t talking about the missing...

2017-06-07T11:01:50-04:00

No, I wasn’t talking about the missing blacklist box. I was talking about how some comments and thumbnails are put next to others instead of all below each other.

Without your CSS - With your CSS

Also note that the quotation boxes don’t stretch to full width even with just one comment per row.

@BrokenEagle98: > kittey said: > > It’s broken when viewing a...

2017-06-07T01:20:26-04:00

kittey said:

It’s broken when viewing a user’s comments or the comment search results (I guess both are the same). Everything else seems to be working fine so far.

@kittey

Are you talking about the missing Blacklist box...? I just noticed that, but it's not an issue with the above CSS, but the fact that Danbooru isn't including the correct HTML for the Javascript to run on. It's basically looking for the "#blacklist-box" and "#blacklist-list" entries, but since they don't exist, there's nothing for the Javascript create from. It still hides the posts, and the above CSS still prevents the flicker. Regardless, will create an issue about the above on GitHub.

Edit:

Created issue #3121.

@kittey: > BrokenEagle98 said: > > It seems like most...

2017-06-06T21:15:21-04:00

BrokenEagle98 said:

It seems like most post previews are block elements, but the child/parent thumbnail previews are inline-block elements. So, I tested out setting all of the post-previews to inline-block, and didn't see any issues with it.
.post-preview.blacklisted {display: inline-block;}
I believe I tested it out on all of the pages with thumbnails, but I might have missed some. If there are any issues with the above, let me know, and I'll create more specific selectors to set the display correctly.

I'll be updating the CSS thread with the above.

It’s broken when viewing a user’s comments or the comment search results (I guess both are the same). Everything else seems to be working fine so far.

@Laethiel: I hope this isn't straying too far off topic,...

2017-06-05T12:38:43-04:00

I hope this isn't straying too far off topic, but this thread brought it to mind, and it can work with BrokenEagle98's CSS above.

This CSS will whitelist your own favorites. It feels a little kludgy, since the list of Blacklisted tags on the left side still thinks they're blacklisted, but it seems to work properly. Note that this CSS means your favorites will never be hidden by your blacklist; they'll always show up, no matter how much you toggle your blacklist on and off.

/*Whitelist own favorites*/
.post-preview[data-is-favorited="true"] {display: inline;}

To combine it with BrokenEagle98's CSS, it goes at the end:

/*Blacklist images hidden, whitelist own favorites*/
.post-preview {display: none;}
.post-preview.blacklisted {display: inline;}
.post-preview.blacklisted-active {display: none;}
.post-preview[data-is-favorited="true"] {display: inline;}

Using the above CSS, your favorites will show up first, then the rest of the non-blacklisted pictures will show up. It's kind of like what normally happens with the blacklist, but in reverse. If you want everything to show up at the same time, the last line needs to be slightly different:

/*Blacklist images hidden, whitelist own favorites*/
.post-preview {display: none;}
.post-preview.blacklisted {display: inline;}
.post-preview.blacklisted-active {display: none;}
.post-preview.blacklisted-active[data-is-favorited="true"] {display: inline;}

@BrokenEagle98: > Type-kun said: > > The thumbnails could get...

2017-06-05T03:17:13-04:00

Type-kun said:

The thumbnails could get appropriate classes during erb processing, and javascript could be used only to hide/unhide the thumbnails.

This would validate the existence of the "dab" cookie, as opposed to making it local/session storage. It doesn't make sense to have cookies if they're only used client-side. It's true that local/session storage doesn't have any expiration, but there's always ways around that, like what is currently being done with autocomplete. I wonder just how many of the cookies could be moved to local/session storage...?

It also removes the need to parse tag strings on client side.

Hopefully the tags will still be kept in. That would allow for Javascript programs with more than one blacklist, for instance.... (like the one I'm currently working on)...

@Type-kun: > evazion said: > > The flickering would be...

2017-06-05T02:45:51-04:00

evazion said:

The flickering would be possible to fix without requiring two types of blacklist. The problem is that thumbnails default to visible and are hidden later by Javascript. If this were reversed, so that thumbnails defaulted to hidden and nonblacklisted posts were unhidden by Javascript, then there would be no opportunity for flickering.

Perhaps the blacklist handling could be moved to server-side? The thumbnails could get appropriate classes during erb processing, and javascript could be used only to hide/unhide the thumbnails. It also removes the need to parse tag strings on client side.

@BrokenEagle98: It seems like most post previews are block...

2017-06-05T00:41:10-04:00

It seems like most post previews are block elements, but the child/parent thumbnail previews are inline-block elements. So, I tested out setting all of the post-previews to inline-block, and didn't see any issues with it.

.post-preview.blacklisted {display: inline-block;}

I believe I tested it out on all of the pages with thumbnails, but I might have missed some. If there are any issues with the above, let me know, and I'll create more specific selectors to set the display correctly.

I'll be updating the CSS thread with the above.

@BrokenEagle98: Yeah, I just noticed that myself... I'll see if...

2017-06-05T00:19:31-04:00

Yeah, I just noticed that myself... I'll see if there's a fix.

@kittey: > BrokenEagle98 said: > > Just figured out a...

2017-06-04T17:40:52-04:00

BrokenEagle98 said:

Just figured out a way to remove the flickering with just CSS.
/*Blacklist images hidden*/
.post-preview {display: none;}
.post-preview.blacklisted {display: inherit;}
.post-preview.blacklisted-active {display: none;}

I just tried your CSS and for me it has the side effect of putting all parent/child thumbnails below each other instead of next to each other. Random example with parent: post #593574

@BrokenEagle98: Just figured out a way to remove the flickering...

2017-06-03T21:33:31-04:00

Just figured out a way to remove the flickering with just CSS.

/*Blacklist images hidden*/
.post-preview {display: none;}
.post-preview.blacklisted {display: inline;}
.post-preview.blacklisted-active {display: none;}

For the above, order is important. The last correct item that addresses the same element is what gets implemented.

1. When page gets loaded, the first line is active, and all posts start out hidden.
2. As the Javascript loads, for...

A. Normal posts: It adds the "blacklisted" class. Since the "blacklist" class appears after the classless item, it unhides them.
B. Blacklist posts: It adds the "blacklisted" and "blacklisted-active" classes. Since the "blacklist-active" appears last, it remains hidden.

Will be adding the above to the CSS thread.

@BrokenEagle98: > evazion said: > > The drawback is the...

2017-06-02T21:32:15-04:00

evazion said:

The drawback is the failure mode: if you have Javascript disabled, or if there's any kind of bug that prevents the Javascript from running, then everything would stay hidden.

Could this be a user-selectable option...? Such an option would control which way posts start out... visible or non-visible. If it starts out defaulting to visible, then there would be no issue. Users would have to manually change it, and therefore manually accept what those changes entails... i.e. Javascript needs to be working.

evazion said:

Also, it should be noted that it's possible to hard blacklist tags in custom CSS:
....

It would be impossible to do complex blacklist strings with that method, e.g. nude -1girl -multiple_girls. Additionally, it would also hide any other tag that contains that term. Tag Search: *photo*

@evazion: Also, it should be noted that it's possible to...

2017-06-02T21:03:09-04:00

Also, it should be noted that it's possible to hard blacklist tags in custom CSS:

[data-tags*="photo"] { display: none; }

This is admittedly more cumbersome and more limited than regular blacklists, but it's possible to do right now.

@evazion: The flickering would be possible to fix without...

2017-06-02T21:00:18-04:00

The flickering would be possible to fix without requiring two types of blacklist. The problem is that thumbnails default to visible and are hidden later by Javascript. If this were reversed, so that thumbnails defaulted to hidden and nonblacklisted posts were unhidden by Javascript, then there would be no opportunity for flickering.

The drawback is the failure mode: if you have Javascript disabled, or if there's any kind of bug that prevents the Javascript from running, then everything would stay hidden.