Embedded notes feature missing?

@BrokenEagle98: Alright, I figured it out. In Firefox, any...

2017-12-02T16:34:11-05:00

Alright, I figured it out. In Firefox, any uncaptured output (in a bookmarklet) gets sent to be rendered on a new page... for reasons unknown. <_<

Regardless, I updated the bookmarklets (forum #135924/forum #136193) taking the above into account, and testing was successful on both Firefox and Chrome.

@kittey: Happens to me too on Firefox ESR 52.5.0.

2017-12-02T16:08:08-05:00

Happens to me too on Firefox ESR 52.5.0.

@BrokenEagle98: Which version of Firefox are you running...? ...

2017-12-02T15:55:18-05:00

Which version of Firefox are you running...?

Edit:

Nevermind, I'm getting the same issue in Firefox 47. <_<

@john1980: The bookmarklet doesn't work for me? 1....

2017-12-02T15:07:19-05:00

The bookmarklet doesn't work for me?

1. Manually create a new bookmark in my browser with the Location set to the code provided above for "Enable embedded notes"
2. Go to a post. ex. post #2942184
3. Run the bookmark
4. Get dialog asking to enable embedded notes.

If choose "OK", get taken to page that simply has text "[object Object]".
If choose "Cancel", get taken to page that says "false".

What is odd is that it works if I run the code directly from the Web Console in Firefox.

@chilled_sake: Does this disable bbcode for links? edit: seems...

2017-11-17T23:27:40-05:00

Does this disable bbcode for links?
edit: seems to be a bug, see issue #3384

@Claverhouse: It seems weird to take away functions and...

2017-11-16T06:40:44-05:00

It seems weird to take away functions and substitute ingenious workarounds, and in addition have all those ingenious workarounds increasingly unknown to average users who then will never know what was once normal.

Emblematic of how the Internet is going forward: eventually all the code will be made by robots aka other code, which they will then take away for our own good.

@BrokenEagle98: Then create an issue and argue your case.

2017-11-11T16:45:28-05:00

Then create an issue and argue your case.

@john1980: > BrokenEagle98 said: > > You can just use the...

2017-11-11T16:18:06-05:00

BrokenEagle98 said:

You can just use the bookmarklets, or whatever other API method you prefer.

I read the thread and saw that, but bookmarklets are just a workaround and not the correct solution.

The feature should continue to be exposed in the UI for both ease and discoverability.

@BrokenEagle98: You can just use the bookmarklets, or whatever...

2017-11-11T16:00:47-05:00

You can just use the bookmarklets, or whatever other API method you prefer.

@john1980: I just went to embed notes and found the option...

2017-11-11T15:38:40-05:00

I just went to embed notes and found the option was gone.

albert said:
It honestly isn't used much at all. It's active on 4450 posts, which represents 1.3% of all posts with notes. For existing posts it'll continue to work (and I suppose you can update it via the API) but I don't think that usage rate warrants taking up screen real estate.

How much real-estate does a single checkbox really take? It's not a good enough reason to remove a feature used on 1000s of posts.

Was the checkbox always showing in the Edit options? If so, then why not only have it show when in Note Editing mode? That would solve any real estate concerns.

@BrokenEagle98: > kittey said: > > IIRC, it’s a builder+...

2017-09-21T12:13:31-04:00

kittey said:

IIRC, it’s a builder+ feature, though, so you probably won’t be able to use it. Ask a builder to enable embedded notes on a post.

It used to be, but it's currently available to all users, which I tested and validated on Testbooru with a Member-level account.

@kittey: > b4z73rd said: > > So, I how do I enable it...

2017-09-21T07:47:23-04:00

b4z73rd said:

So, I how do I enable it with those bookmarklets?

Go to your browser’s bookmark manager, create a new bookmark and put one of BrokenEagle’s code snippets into the URL field.

When you’re viewing a post that you want to enable/disable embedded notes on, click on the corresponding bookmark from your browser’s bookmark menu.

IIRC, it’s a builder+ feature, though, so you probably won’t be able to use it. Ask a builder to enable embedded notes on a post.

@b4z73rd: So, I how do I enable it with those bookmarklets?

2017-09-21T07:17:36-04:00

So, I how do I enable it with those bookmarklets?

@Unbreakable: Well that's kinda sad but I guess we'll survive...

2017-09-20T00:16:24-04:00

Well that's kinda sad but I guess we'll survive without it, I forsee a lot more tapping on my phone in the future.

@BrokenEagle98: Got the word back in commit b361809 that the...

2017-09-19T23:41:56-04:00

Got the word back in commit b361809 that the removal of this option from the edit tab is more of a permanent thing.

albert said:

It honestly isn't used much at all. It's active on 4450 posts, which represents 1.3% of all posts with notes. For existing posts it'll continue to work (and I suppose you can update it via the API) but I don't think that usage rate warrants taking up screen real estate.

That being confirmed, I'll go ahead and copy the above sets of bookmarklets to topic #8502 and update about:userscripts.

@BrokenEagle98: In the interim, I created the following...

2017-09-15T21:43:16-04:00

In the interim, I created the following bookmarklets for enabling and disabling embedded notes. Depending on whether this option comes back or is completely removed, ~~I'll move it to topic #8502~~. It's been copied to forum #136193. Will eventually remove the code below so it won't need to be maintained in two separate locations.

Enable embedded notes

javascript:var conf=confirm("Enable embedded notes?");if (conf){var temp=$.ajax({type:"PUT",url:"/posts/"+Danbooru.meta("post-id")+".json",data:{'post':{"has_embedded_notes":true}},success:(data)=>{Danbooru.notice("Settings updated.");window.location=window.location;},error:(data)=>{Danbooru.notice("Error updating settings!");}});};

Disable embedded notes

javascript:var conf=confirm("Disable embedded notes?");if (conf){var temp=$.ajax({type:"PUT",url:"/posts/"+Danbooru.meta("post-id")+".json",data:{'post':{"has_embedded_notes":false}},success:(data)=>{Danbooru.notice("Settings updated.");window.location=window.location;},error:(data)=>{Danbooru.notice("Error updating settings!");}});};

Edit:

(2017-12-02)

Updated bookmarklet code for Firefox <john1980: forum #140081>

@Unbreakable: It was certainly useful when viewing posts on a...

2017-09-15T21:02:53-04:00

It was certainly useful when viewing posts on a phone since you don't have to tap each and every note to read them, even more when there are a bunch of small ones.

@DeusExCalamus: I'm glad it was removed, TBH. I didn't care for...

2017-09-15T20:53:52-04:00

I'm glad it was removed, TBH. I didn't care for it and thought it didn't add much of value to the site. I much prefer the old way, though I wouldn't be opposed to it being added back with a toggle to allow the user to select whether they see embedded notes or not.

@BrokenEagle98: It was removed in commit b361809 for some...

2017-09-15T19:24:50-04:00

It was removed in commit b361809 for some reason...? I frequently use the option myself, but there was no reasoning left behind, so I don't know... I left a comment behind on that particular commit asking why, but I don't know if there'll be a response.

@b4z73rd: I'm not sure what's going on, but usually I...

2017-09-15T19:16:08-04:00

I'm not sure what's going on, but usually I find the check box for embed notes in the edit tab, and it's not there anymore. What gives? It's not like embedded notes got dropped because all of the comics I posted before still have embedded notes.