Danbooru 2 Issues Topic

@Unbreakable: > Etou said: > > Recent performance reports...

2020-04-03T20:25:10-04:00

Etou said:

Recent performance reports under contributor uploads are blank. https://isshiki.donmai.us/user-reports/contributor_uploads/

Most of those reports has been broken since the start of the year, see issue #4367

@Etou: Recent performance reports under contributor...

2020-04-03T19:12:46-04:00

Recent performance reports under contributor uploads are blank. https://isshiki.donmai.us/user-reports/contributor_uploads/

@Zurreak: Text which is displayed partially or fully...

2020-04-03T05:47:43-04:00

Text which is displayed partially or fully outside of the note box is now visible even in non-embedded notes. This is a problem because it did not used to be the case. In posts like post #3341502 where the text is supposed to be cut off, it is instead fully displayed and simply looks like a non-sequitur.

@nonamethanks: > Etou said: > > post #3843576 > post #3843577...

2020-04-01T18:50:00-04:00

Etou said:

post #3843576
post #3843577
post #3843582

As I mentioned in BE98's issue, you can just change the domain to use "<artist-name>.tumblr.com", as it's just a redirect. The issue however is that the bookmarklet still doesn't detect pictures bigger than 1280x1920, so it would not have picked the full size had you used it (issue #4324).

@BrokenEagle98: > Etou said: > > post #3843576 > post #3843577...

2020-04-01T11:55:47-04:00

Etou said:

post #3843576
post #3843577
post #3843582

Alright, I see. Those aren't using the traditional Tumblr URL format, so the site doesn't detect it as a Tumblr link.

Edit:

Created issue #4380.

@Etou: > BrokenEagle98 said: > > Well since you...

2020-04-01T09:26:43-04:00

BrokenEagle98 said:

Well since you didn't actually give any posts, I had to guess and picked post #3840236, which still also works for me.

post #3843576
post #3843577
post #3843582

@BrokenEagle98: > Etou said: > > All of my recent posts from...

2020-03-31T20:50:29-04:00

Etou said:

All of my recent posts from tumblr.

Well since you didn't actually give any posts, I had to guess and picked post #3840236, which still also works for me.

@Etou: > BrokenEagle98 said: > > Example? It's...

2020-03-31T20:29:06-04:00

BrokenEagle98 said:

Example? It's working for me still.

All of my recent posts from tumblr.

@BrokenEagle98: > Etou said: > > Bookmarklet isn't grabbing...

2020-03-31T20:12:40-04:00

Etou said:

Bookmarklet isn't grabbing tumblr images anymore.

Example? It's working for me still.

@Etou: Bookmarklet isn't grabbing tumblr images anymore.

2020-03-31T20:07:10-04:00

Bookmarklet isn't grabbing tumblr images anymore.

@BrokenEagle98: > kittey said: > > Yes, that’s exactly where I...

2020-03-31T12:37:11-04:00

kittey said:

Yes, that’s exactly where I went. I tried both.

I got it now. The problem was that the revert links – and only the revert links – are off-screen. There’s a lot of blank space in the middle and the whole list basically looks the same as the list without the revert links, including the properly centered footer. See here. (All user CSS is off, btw.)

Edit: Apparently the table width is set to 100% but the thumbnail is not part of it, so the full-width table is placed next to the thumbnail inside a flex environment, resulting in the off-screen overhang.

Yeah, I see. It's not doing that in Chrome, which is why I didn't notice it. I tested it on Firefox which is where I saw the issue. I'll go ahead and file an issue for that.

Edit:

Created issue #4378.
Created PR #4379

@kittey: > BrokenEagle98 said: > > You have to click...

2020-03-31T12:14:35-04:00

BrokenEagle98 said:

You have to click the version links as I said. See the following for where I outlined them.

https://cdn.discordapp.com/attachments/618878216815247372/694576455304216596/unknown.png

That particular view also becomes available when you click the "Commentary" link under History on a post.

Yes, that’s exactly where I went. I tried both.

I got it now. The problem was that the revert links – and only the revert links – are off-screen. There’s a lot of blank space in the middle and the whole list basically looks the same as the list without the revert links, including the properly centered footer. See here. (All user CSS is off, btw.)

Edit: Apparently the table width is set to 100% but the thumbnail is not part of it, so the full-width table is placed next to the thumbnail inside a flex environment, resulting in the off-screen overhang. The commentary history without the revert links has the thumbnail inside the table, so everything fits.

@BrokenEagle98: > kittey said: > > Sorry, I can’t figure out...

2020-03-31T12:00:31-04:00

kittey said:

Sorry, I can’t figure out how to revert commentary changes. Even when I click on the version link or use the commentary history link from a post, I don’t see any revert links. Clicking previous/subsequent/current anywhere doesn’t help either. :-?

You have to click the version links as I said. See the following for where I outlined them.

https://cdn.discordapp.com/attachments/618878216815247372/694576455304216596/unknown.png

That particular view also becomes available when you click the "Commentary" link under History on a post.

@kittey: > BrokenEagle98 said: > > You have to click...

2020-03-31T11:55:16-04:00

BrokenEagle98 said:

You have to click the version link which will then drill down to the searching commentary by post.

For most items on this site, the revert links only become visible when searching by the instance types that they are attached to. This is because the revert links have no context when they are just in the general listing.

Sorry, I can’t figure out how to revert commentary changes. Even when I click on the version link or use the commentary history link from a post, I don’t see any revert links. Clicking previous/subsequent/current anywhere doesn’t help either. :-?

As for undo links, they are only available on post versions at this time.

Alright.

Several improvement in the post versions are already being made in issue #4369. If you have any suggestions beyond those, then those could be considered and added in as well.

Those planned changes look good. It’s just very hard to sift through tag vandalism at the moment because highlighting of obsolete changes was removed before the new style was rolled out.

@Paracite: I've been using an incredibly old script,...

2020-03-31T11:32:10-04:00

I've been using an incredibly old script, Danbooru Note Assist which hasn't been updated in 5-odd years; the recent updates to the site seem to have broken its functionality completely.

I'm no programmer, so I don't know how it could be fixed (or at all); however, it's still on the about:userscripts page, so if nothing else it should be removed from there if it's permanently non-functional.

@BrokenEagle98: > kittey said: > > Is the undo link in the...

2020-03-31T11:31:57-04:00

kittey said:

Is the undo link in the commentary history gone or am I remembering incorrectly and there was never one there in the first place?

You have to click the version link which will then drill down to the searching commentary by post.

For most items on this site, the revert links only become visible when searching by the instance types that they are attached to. This is because the revert links have no context when they are just in the general listing. As for undo links, they are only available on post versions at this time.

Also, are obsolete tag changes in the tag history not marked anymore? Previously, the +/- on obsolete changes were black and the green/red colors were darker.

Several improvement in the post versions are already being made in issue #4369. If you have any suggestions beyond those, then those could be considered and added in as well.

@kittey: Is the undo link in the commentary history gone...

2020-03-31T11:10:14-04:00

Is the undo link in the commentary history gone or am I remembering incorrectly and there was never one there in the first place?

Also, are obsolete tag changes in the tag history not marked anymore? Previously, the +/- on obsolete changes were black and the green/red colors were darker.

@evazion: > CodeKyuubi said: > > Been a while since it...

2020-03-31T02:45:11-04:00

CodeKyuubi said:

Been a while since it started happening, but was removing tags from page cookies/cache intended? It kind of sucks when my browser crashes and I lose all the tags and links I had in like 6-10 upload tabs.

Saving form values on the uploads page is something your browser is doing, not us. Some browsers (Firefox in particular) are known to save form values and autofill them when you reload the page. We disabled this behavior for Firefox because there were cases where it broke things in very mysterious ways. One case was when an approver would approve a post then try to edit the tags, the tag edit would fail because Firefox tried to autofill stale form values.

@evazion: Update* Fixed translation note popups appearing...

2020-03-31T02:35:10-04:00

Update

Fixed translation note popups appearing too wide or too narrow.
Fixed translation notes appearing above site notices (i.e. the "You have favorited this post" message).

@CodeKyuubi: Been a while since it started happening, but...

2020-03-31T01:27:33-04:00

Been a while since it started happening, but was removing tags from page cookies/cache intended? It kind of sucks when my browser crashes and I lose all the tags and links I had in like 6-10 upload tabs.