Danbooru

Danbooru 2 Issues Topic

Posted under General

BrokenEagle98 said:

You have to click the version link which will then drill down to the searching commentary by post.

For most items on this site, the revert links only become visible when searching by the instance types that they are attached to. This is because the revert links have no context when they are just in the general listing.

Sorry, I can’t figure out how to revert commentary changes. Even when I click on the version link or use the commentary history link from a post, I don’t see any revert links. Clicking previous/subsequent/current anywhere doesn’t help either. :-?

As for undo links, they are only available on post versions at this time.

Alright.

Several improvement in the post versions are already being made in issue #4369. If you have any suggestions beyond those, then those could be considered and added in as well.

Those planned changes look good. It’s just very hard to sift through tag vandalism at the moment because highlighting of obsolete changes was removed before the new style was rolled out.

Updated

kittey said:

Sorry, I can’t figure out how to revert commentary changes. Even when I click on the version link or use the commentary history link from a post, I don’t see any revert links. Clicking previous/subsequent/current anywhere doesn’t help either. :-?

You have to click the version links as I said. See the following for where I outlined them.

https://cdn.discordapp.com/attachments/618878216815247372/694576455304216596/unknown.png

That particular view also becomes available when you click the "Commentary" link under History on a post.

BrokenEagle98 said:

You have to click the version links as I said. See the following for where I outlined them.

https://cdn.discordapp.com/attachments/618878216815247372/694576455304216596/unknown.png

That particular view also becomes available when you click the "Commentary" link under History on a post.

Yes, that’s exactly where I went. I tried both.

I got it now. The problem was that the revert links – and only the revert links – are off-screen. There’s a lot of blank space in the middle and the whole list basically looks the same as the list without the revert links, including the properly centered footer. See here. (All user CSS is off, btw.)

Edit: Apparently the table width is set to 100% but the thumbnail is not part of it, so the full-width table is placed next to the thumbnail inside a flex environment, resulting in the off-screen overhang. The commentary history without the revert links has the thumbnail inside the table, so everything fits.

Updated

kittey said:

Yes, that’s exactly where I went. I tried both.

I got it now. The problem was that the revert links – and only the revert links – are off-screen. There’s a lot of blank space in the middle and the whole list basically looks the same as the list without the revert links, including the properly centered footer. See here. (All user CSS is off, btw.)

Edit: Apparently the table width is set to 100% but the thumbnail is not part of it, so the full-width table is placed next to the thumbnail inside a flex environment, resulting in the off-screen overhang.

Yeah, I see. It's not doing that in Chrome, which is why I didn't notice it. I tested it on Firefox which is where I saw the issue. I'll go ahead and file an issue for that.

Edit:

Created issue #4378.
Created PR #4379

Updated

Etou said:

Bookmarklet isn't grabbing tumblr images anymore.

Example? It's working for me still.

BrokenEagle98 said:

Example? It's working for me still.

All of my recent posts from tumblr.

Etou said:

All of my recent posts from tumblr.

Well since you didn't actually give any posts, I had to guess and picked post #3840236, which still also works for me.

Etou said:

post #3843576
post #3843577
post #3843582

As I mentioned in BE98's issue, you can just change the domain to use "<artist-name>.tumblr.com", as it's just a redirect. The issue however is that the bookmarklet still doesn't detect pictures bigger than 1280x1920, so it would not have picked the full size had you used it (issue #4324).

Text which is displayed partially or fully outside of the note box is now visible even in non-embedded notes. This is a problem because it did not used to be the case. In posts like post #3341502 where the text is supposed to be cut off, it is instead fully displayed and simply looks like a non-sequitur.