visor can be a bit ambiguous, how about sun_visor or sun_cap / hat when it comes to the hat style and something else for the glasses?

It also seems to be used for hats with a long or wide visor.

I think visor_cap or sports_visor (going by wikipedia) would probably be better. While we might have few or no images of it, apparently "sun visor" can refer to a lot of other things, particularly parts on and in a cars and other vehicles, as well as specific internal and external visors in helmets designed specifically to shade the eyes from sun.

although rare, what of images such as (post #764764)? Not in a sports setting, unless this is meant to describe the style of the headgear in general.

It's apparently the style in general. The wikipedia link says that they were designed for outdoor sports (such as volleyball, tennis, and golf), not sure how accurate that is though.

It's also used for helmet visors, IIRC, and head mounted displays tend to get lumped in there.
Maybe helmet_visor or visored_helmet for the helmets, though that's still ambiguous regarding transparent vs. medieval style visors.

unicogirl said:
although rare, what of images such as (post #764764)? Not in a sports setting, unless this is meant to describe the style of the headgear in general.

I think visor_cap works for them as well. Though googling for it, half the results are of military caps. Should they be included?

I'd say go with visor_cap

zatchii said:
It's also used for helmet visors, IIRC, and head mounted displays tend to get lumped in there.
Maybe helmet_visor or visored_helmet for the helmets, though that's still ambiguous regarding transparent vs. medieval style visors.

I think visor_cap works for them as well. Though googling for it, half the results are of military caps. Should they be included?

What would work best based on Danbooru, visor_cap would be it, but sports_visor gets more image hits that make sense.

I think the military caps show up do to it being peaked cap with a noticeable visor. But Ack, *face palm* I think I misinterpreted the meaning, perhaps the peak was the body not the visor. So does that name need to be discussed for something new jxh2154? Obviously a wiki edit is in order.