Danbooru

Danbooru 2 Issues Topic

Posted under General

Anyone getting a "wrong number of arguments (given 0, expected 1)" error? Clicking or manually typing a tag produces the error.

nanami said:

Anyone getting a "wrong number of arguments (given 0, expected 1)" error? Clicking or manually typing a tag produces the error.

Yeap.

Site update

Changes

Added the following search metatags:

  • comment:blah - find posts with comments saying "blah".
  • note:blah - find posts with notes saying "blah".
  • ordfavgroup:blah - find posts in favgroup "blah", in the same order they were added to the favgroup.
  • order:md5 - find posts ordered by MD5. Useful for ordering posts in a random (but fixed) order.
  • order:none - find posts in no particular order (not guaranteed to be completely random, but usually close to it).
Fixes
  • Fixed the "This tag is under discussion" notice still appearing even after the bulk update request has been approved or rejected.
  • Fixed aliases incorrectly copying the tag category when aliasing a non-general tag to another non-general tag (e.g. aliasing a character tag to a copyright tag would turn the copyright tag into a character).

Full changelog: https://github.com/danbooru/danbooru/compare/production-2020.04.21-070050-utc...production-2020.04.28-055724-utc

Some "order:" commands dont't work correctly after last update.
For example "order:rank order:favcount" shows all "order:rank" pics without "favcount" sorting and indicates indefinite number of pages (which is in fact not true). Also loading is too long.
And vice versa, when you type "order:favcount order:rank" it shows only favcount sorting while ignoring posts from "hot".
Both commands work fine individually or with some other commands.
Also it looks like "-fav:username" sometimes tries to load just every pic you don't have in your favourites, ignoring other tags. Don't really see any exact pattern of how it works right now.
Hope it will be fixed soon.

wooooohooooo said:

Some "order:" commands dont't work correctly after last update.
For example "order:rank order:favcount" shows all "order:rank" pics without "favcount" sorting and indicates indefinite number of pages (which is in fact not true). Also loading is too long.
And vice versa, when you type "order:favcount order:rank" it shows only favcount sorting while ignoring posts from "hot".
Both commands work fine individually or with some other commands.

Not sure what you're trying to do, but of course two orders won't work. The second is being discarded because there can't logically be two different orderings at the same time of the same posts.

Also it looks like "-fav:username" sometimes tries to load just every pic you don't have in your favourites, ignoring other tags. Don't really see any exact pattern of how it works right now.
Hope it will be fixed soon.

It works fine here, for example: -fav:nonamethanks user:nonamethanks. What searches are you trying with that tag?

nonamethanks said:

Not sure what you're trying to do, but of course two orders won't work. The second is being discarded because there can't logically be two different orderings at the same time of the same posts.

Funny to see this "of course".
You see, I don't know all these terms well, but order:rank is kind of pool of pics, not a real ordering. And it worked perfectly fine with order:favcount for AGES untill this time. It is a fact. I know it because I constantly used it and it always worked since I'm here. It means 8 years, maybe some years less, don't remember exactly when I tried it for a first time. 2 years as minimum, let's just say.
That's the reason I write here, it's pretty annoying to break habits because of I dunno even what.

It works fine here, for example: -fav:nonamethanks user:nonamethanks. What searches are you trying with that tag?

Try just "-fav:username" first and start adding more and more random tags. Even if you see "Nobody here but us chickens!" in result, there still will be from 1 to 5 pages down below with "...". That's definetly not alright. Without "-fav:username" I see "...chickens!" and "< 1 >" down below, as it supposed to be seen.
Most annoying thing is that every time it's loading noticeably longer like it tries to load just everything without tags restrictions.

wooooohooooo said:

Try just "-fav:username" first and start adding more and more random tags. Even if you see "Nobody here but us chickens!" in result, there still will be from 1 to 5 pages down below with "...". That's definetly not alright. Without "-fav:username" I see "...chickens!" and "< 1 >" down below, as it supposed to be seen.
Most annoying thing is that every time it's loading noticeably longer like it tries to load just everything without tags restrictions.

The more tags you add, the less results there are and the more back in time the database needs to go to fill up one page of thumbnails, which is why it keeps taking longer and longer. Nothing unusual there.

The nonsensical paginator at the bottom is a result of that: if it takes to long to find out how many results there are in total to display the end of the paginator, the site just gives up trying and gives you an infinite paginator with “…” at the end. That could probably be made smarter, but I guess nobody felt the need to put work into that since users were expected to figure out that the paginator does nothing if there aren’t any results.

Btw, none of that is restricted to -fav:username searches. Any search with lots of tags and few results will show that behavior.

wooooohooooo said:

Funny to see this "of course".
You see, I don't know all these terms well, but order:rank is kind of pool of pics, not a real ordering. And it worked perfectly fine with order:favcount for AGES untill this time. It is a fact. I know it because I constantly used it and it always worked since I'm here. It means 8 years, maybe some years less, don't remember exactly when I tried it for a first time. 2 years as minimum, let's just say.
That's the reason I write here, it's pretty annoying to break habits because of I dunno even what.

Maybe @evazion can confirm, but it seems to me that order:rank is just score:>0 age:<2d with custom weighted sorting, so maybe score:>0 age:<2d order:favcount is what you want.

Fixed an issue with the paginator and sidebar not showing up when searching for an aliased tag.

nonamethanks said:

Maybe @evazion can confirm, but it seems to me that order:rank is just score:>0 age:<2d with custom weighted sorting, so maybe score:>0 age:<2d order:favcount is what you want.

This is correct. order:rank is basically high scoring posts from the last two days, with a score decay factor so that new posts outrank older posts.

The previous behavior was that order:rank order:favcount was effectively the same thing as age:<2d score:>0 order:favcount. This was considered a bug because using order:favcount to partially override order:rank wasn't the intended behavior of these tags.

(The exact order:rank formula is log(3, score) + (upload_date - 2005-05-24) / 35000. This is based on Reddit's hot ranking algorithm; see https://www.evanmiller.org/deriving-the-reddit-formula.html for details).

Updated

Some of my saved searches seem to be ignoring some excluded tags. For example, I saved status:any yes-no_pillow -yes -no -rating:e id:3217323.., which returns nothing when run manually. However, the list of saved searches says that there are 19 results and when I run a search for the saved searches group’s label, I get 16 explicit results that should’ve been excluded. I also have a saved search for status:any alpha_transparency -filetype:png, which also returns nothing when run manually, but the list of saved searches says there are 728 results and a search for the label shows loads of PNGs that should’ve been excluded.

Anyone else finding supposedly excluded posts in their saved searches?

Fixed an issue where searches with negated metatags returned incorrect post counts. This also caused wrong page counts when using the "Deleted post filter" account setting and wrong post counts in saved searches involving negated metatags.

nonamethanks said:

Maybe @evazion can confirm, but it seems to me that order:rank is just score:>0 age:<2d with custom weighted sorting, so maybe score:>0 age:<2d order:favcount is what you want.

Yes, it is. Thank you!

evazion said:

Fixed an issue where searches with negated metatags returned incorrect post counts. This also caused wrong page counts when using the "Deleted post filter" account setting and wrong post counts in saved searches involving negated metatags.

And thank you too!

DreamFromTheLayer said:

A small request, but I'd like the report comment dialogue box to have a link to the howto:comment page.

The report dialogue is unique for all report forms, and it can be found here: help:report_notice. Since it's a wiki page loaded via javascript by the report button, it's editable by any builder.
But there probably should be a different report form for forums and comments, so that more detailed guidelines can be added for each case. Not sure though if that's warranted, as I have no idea how many reports are submitted on average.

Just for the record, these are all the editable loaded forms.

Edit: opened issue #4434.

Updated